search

allegroai / clearml-server-helm

ClearML Server for Kubernetes Clusters Using Helm
https://allegroai.github.io/clearml-server-helm/
Other
17 stars 15 forks source link

[JustANit] Revise Helm Charts #4

Open DarkBlaez opened 4 years ago

DarkBlaez commented 4 years ago

Just a nit, the helm charts seem like an after thought and just a mess. Did anyone follow good adherence to how other charts are structured to include a well structured and commented values.yaml. Obviously as is the helm chart fails to run since storage and claims were left out. I'll fork this and create a set of helm charts that are more robust. Seems like if you want individuals to adopt this and for TRAINS to become more of a standard or of high use that things would be structured in a way that insures first launch from the helm chart. I always challenge my own devs to do a clean deploy to insure success on all first-launches

DB

bmartinn commented 4 years ago

Hi @DarkBlaez , Yes you are absolutely correct in your observation. We are working on tidying things up, and to be honest I think this repository should probably be deprecated in favor of https://github.com/allegroai/trains-server-k8s . It only makes sense to keep it as charts tgz storage and not actual place to edit the helm yaml files. Please feel free to fork the trains-server-k8s repo, we :heart: PRs :)

What do you think?

DarkBlaez commented 4 years ago

I'll look at the other repo and create a set of helm charts that provide the necessary setup for a full installation. I'll then send a pull request.