Closed Shaked closed 4 years ago
Hey @Shaked,
Thanks for your contribution, this looks great! What's the reason for the changes in the files under the trains-server-k8s folder?
@psrosa
Thank you!
What's the reason for the changes in the files under the trains-server-k8s folder?
It's a mistake, didn't notice I was editing the wrong files 😐
@Shaked Do you want to update the pull request or can I revert these files?
Hey,
As mentioned in https://github.com/allegroai/trains-server-helm/issues/3, I have created a PR that allows developers to quickly setup their ingress. This can be done by using:
Once
ingress.enabled
is set totrue
theingress.host
parameter is required (but I didn't find a way to throw an exception if not set). Annotations and secretName are up to developers in case needed.The above should generate this YAML:
I have also moved the
containers.resources
tovalues.yaml
so that it will be easier to change in case needed:This can be set by using:
--set apiserver.resources.requests.memory="500m" --set apiserver.resources.limits.memory="500m"
What do you think?
Thank you! Shaked