search

allegroai / clearml-server

ClearML - Auto-Magical CI/CD to streamline your AI workload. Experiment Management, Data Management, Pipeline, Orchestration, Scheduling & Serving in one MLOps/LLMOps solution
https://clear.ml/docs
Other
364 stars 132 forks source link

Correct nginx proxy Host header #210

Open chriswue opened 11 months ago

chriswue commented 11 months ago

The Host header should be the target host not the source host. Fixes #209

jkhenning commented 11 months ago

Hi @chriswue, I just want to be absolutely sure, but it seems this change contradicts the example shown here: http://nginx.org/en/docs/http/ngx_http_proxy_module.html Can you please shed some more light on this?

chriswue commented 11 months ago

@jkhenning Not sure which example you refer to specifically but this corroborates what I'm talking about: image

Dominik-Weinzierl commented 2 months ago

Any updates on this pull request? We would need that change as well. Thank you!

jkhenning commented 2 months ago

@chriswue , since your change basically changes it back to the default, wouldn't it be better just to remove this line?

Dominik-Weinzierl commented 2 months ago

That should work as well (but i am not sure), yes 🤔

Edit: Somehow deleting all pods and volumes and installing version 7.8.2 fixed the issue for us - so right now no need to change something.