AWS driver fixes

[achaiah]

Related Issue \ discussion

N/A

Patch Description

• Fixes AWS credential access that uses a token - existing code does not take into consideration AWS credentials that use key/secret/token triplet to access resources.

• Fixes instantiation within VPC without AvailabilityZones. In these situations you must supply a SubnetID instead of AvailabilityZone.

• Extends EBS volume creation to include existing volumes (specified by ebs_snapshot_id). Note: In current code implementation EBS is attached but never mounted.

Testing Instructions

Credential authentication fails when attempting to use key/secret/token (due to the obvious lack of ability to specify a token)

SubnetID is a required parameter in certain VPC configurations where Availability Zones are not configured.

Other Information

[jkhenning]

@achaiah is this still relevant?

[achaiah]

Yes, this is still definitely an issue unless it has been fixed separately from this PR.

[jkhenning]

OK, do you have any reply for the question I raised in the code comment?

[achaiah]

I did reply to your question above. At this moment I don't have official AWS documentation beyond what the AWS API error message requested me to supply (i.e. SubnetId is required if no default AvailabilityZone is configured).

[jkhenning]

I'm sorry, I didn't see the reply...