pytorch lightning model saving not working with new namespace

allegroai / clearml

ClearML - Auto-Magical CI/CD to streamline your AI workload. Experiment Management, Data Management, Pipeline, Orchestration, Scheduling & Serving in one MLOps/LLMOps solution

https://clear.ml/docs

Apache License 2.0

5.61k stars 651 forks source link

pytorch lightning model saving not working with new namespace #1032

Closed aweinmann closed 1 year ago

aweinmann commented 1 year ago

PyTorch lightning got renamed to lightning and this changed the namespace to lightning. While the old namespace is still supported the new one does not work with ClearML with regards to model checkpoint saving.

The trainer got moved from pytorch_lightning to lightning.pytorch and thus https://github.com/allegroai/clearml/blob/66061af1aaa5b3bc447e22da6abac2a966653829/clearml/binding/frameworks/pytorch_bind.py#L113 and the following lines will not work when using the new namespace

ainoam commented 1 year ago

Thanks for noting @aweinmann.

Would you like to issue a PR?