allegroai / clearml

ClearML - Auto-Magical CI/CD to streamline your AI workload. Experiment Management, Data Management, Pipeline, Orchestration, Scheduling & Serving in one MLOps/LLMOps solution
https://clear.ml/docs
Apache License 2.0
5.69k stars 655 forks source link

Dataset.list_dataset() partial match doesn't work with speical charcters #1076

Closed natephysics closed 1 year ago

natephysics commented 1 year ago

Describe the bug

Dataset.list_dataset() partial match option doesn't escape special characters, which breaks matching in many cases. Tracing it back, Task._query_tasks() task_name doesn't work with special characters either. I plan to offer a PR with the fix at the _query_tasks() level unless there's a compelling reason otherwise.

To reproduce

List datasets with a task name with characters that need to be escaped normally. An example, [ABC] Name won't match even if the task name is identical.

Expected behaviour

Without any mention of needing to escape special characters, it might make more sense to do it by default.

jkhenning commented 1 year ago

@natephysics docstrings were updated to reflect this, as discussed in #1077. I'm closing this 🙂