allegroai / clearml

ClearML - Auto-Magical CI/CD to streamline your AI workload. Experiment Management, Data Management, Pipeline, Orchestration, Scheduling & Serving in one MLOps/LLMOps solution
https://clear.ml/docs
Apache License 2.0
5.61k stars 651 forks source link

Task.set_script bug #1106

Open MaxVanHoucke opened 1 year ago

MaxVanHoucke commented 1 year ago

Describe the bug

When using Task.set_script and setting some parameters to the empty string (""), the values are not reset as would be expected. In the method code, the empty string is replaced by a python None, which seems to do nothing in the API call.

To reproduce

After cloning a task that has a repository, try to reset the repository by calling task.set_script(repository="")

Expected behaviour

The repository entry should be cleared, as mentioned in the docs.

Environment

ainoam commented 1 year ago

Thanks for reporting @MaxVanHoucke.

We'll update when a fix is available.

MaxVanHoucke commented 1 year ago

Thanks! For now I'm using the following workaround

script = new_task.data.script
script.repository = ''
new_task._update_script(script)
pollfly commented 10 months ago

Hey @MaxVanHoucke! Just letting you know that this issue has been resolved in the recently released v1.13.2. Let us know if there are any issues :)