add_histogram method calls report_surface with hard-coded iteration=0

allegroai / clearml

ClearML - Auto-Magical CI/CD to streamline your AI workload. Experiment Management, Data Management, Pipeline, Orchestration, Scheduling & Serving in one MLOps/LLMOps solution

https://clear.ml/docs

Apache License 2.0

5.58k stars 644 forks source link

add_histogram method calls report_surface with hard-coded iteration=0 #666

Open vfdev-5 opened 2 years ago

vfdev-5 commented 2 years ago

Hi,

we are wondering about this hard-coded value and especially that it is visible in UI. Specifying step value however does not display it anywhere...

https://github.com/allegroai/clearml/blob/90d060dd7e5f41e2359a6286902c05b5620d31a8/clearml/binding/frameworks/tensorflow_bind.py#L220

Context: https://github.com/pytorch/ignite/pull/2550#issuecomment-1115543004

Anything we can do with that or use some other more appropriate classes ? Thanks

jkhenning commented 2 years ago

Hi @vfdev-5,

This is indeed strange, I'll take a look

eugen-ajechiloae-clearml commented 2 years ago

Hi @vfdev-5! Iteration is hardcoded to 0 here because it is not relevant. All the histograms corresponding to a certain name are aggregated in one single surface that has the iteration of each corresponding histogram on the yaxis. In the surface that I saw in your related issue, the step would be here: If we were to set the step there, there would be a lot of surfaces being displayed, each one with a higher iteration number including the others:

vfdev-5 commented 2 years ago

@eugen-ajechiloae-clearml thanks for the answer! It makes sense. However, it would be nice to avoid duplicated info like "Iteration 0" in the title and the axis.

eugen-ajechiloae-clearml commented 2 years ago

@vfdev-5 Great news, we actually don't display that redundant Iteration 0 anymore, this got fixed in the meantime