search

allegroai / clearml

ClearML - Auto-Magical CI/CD to streamline your AI workload. Experiment Management, Data Management, Pipeline, Orchestration, Scheduling & Serving in one MLOps/LLMOps solution
https://clear.ml/docs
Apache License 2.0
5.69k stars 655 forks source link

Create pylint.yml #972

Closed bai2020-05 closed 8 months ago

bai2020-05 commented 1 year ago

Related Issue \ discussion

If this patch originated from a github issue or slack conversation, please paste a link to the original discussion

Patch Description

Description of what does the patch do. If the patch solves a bug, explain what the bug is and how to reproduce it (If not already mentioned in the original conversation)

Testing Instructions

Instructions of how to test the patch or reproduce the issue the patch is aiming to solve

Other Information

jkhenning commented 1 year ago

@bai2020-05 can you please provide some context for this PR?

john-zielke-snkeos commented 1 year ago

I just discovered this PR after opening my issue: #973 .Maybe this aims to do something similar.

jkhenning commented 1 year ago

@bai2020-05 , I think that since we internally use Flake8, we should start with it - WDYT?

john-zielke-snkeos commented 1 year ago

Yes, Flake8 is definitely a good idea, but does it provide auto-formatting as well? I have used Flake8 for the linting, but not for the code formatting, but if it provides that as well, it would be enough

jkhenning commented 1 year ago

@bai2020-05 is this still relevant?

john-zielke-snkeos commented 1 year ago

I am not sure it is relevant for the author, but it is still relevant in general IMO

jkhenning commented 1 year ago

@john-zielke-snkeos Since we use Flake8 internally (btw I think its much more common for open source projects), I think we should have a new PR using it, WDYT?

john-zielke-snkeos commented 1 year ago

Yes, it probably makes sense if you just add your config/setup for this to the repo so other contributors can easily use that.