Typo in storage protocol in Logger documentation

allegroai / clearml

ClearML - Auto-Magical CI/CD to streamline your AI workload. Experiment Management, Data Management, Pipeline, Orchestration, Scheduling & Serving in one MLOps/LLMOps solution

https://clear.ml/docs

Apache License 2.0

5.69k stars 655 forks source link

Typo in storage protocol in Logger documentation #986

Closed charlienewey closed 1 year ago

charlienewey commented 1 year ago

Describe the bug

There's a slightly misleading typo in the Logger documentation for the set_default_upload_destination method.

To reproduce

See: https://clear.ml/docs/latest/docs/references/sdk/logger/#set_default_upload_destination Google's GCS protocol is noted as gc:// instead of the correct gs://

charlienewey commented 1 year ago

only smol issue btw

ainoam commented 1 year ago

Thanks for noticing @charlienewey.

Care to PR?

pzarfos commented 1 year ago

@ainoam Here is a PR to fix the doc comment for gs://

https://github.com/allegroai/clearml/pull/1018

ainoam commented 1 year ago

Many thanks @pzarfos!!

jkhenning commented 1 year ago

Closing as #1018 was merged some time ago.