allegroplanet / allegro-planet

1 stars 1 forks source link

Remove Legacy String Validation #28

Closed MarkOates closed 7 years ago

MarkOates commented 7 years ago

Problem

In the beginning, validations on the models were originally created using an EmailFormat concern and a StringFormat concern with regexes and messages. Later, a custom validator, StringFormatValidator, was used that generates better error messages and is more developer-friendly.

However, there is still some usage of the older EmailFormat and StringFormat concerns.

Solution

Remove the EmailFormat and StringFormat and replace them with the new StringFormatValidator.

Also

Two tangentially related things have been added/changed: