search

allejo / bzion

A League Management System designed for BZFlag leagues and tournaments.
https://leaguesunited.org/
Other
20 stars 10 forks source link

Ban editor - removing a ban returns you to ban details page. #112

Open asinck opened 7 years ago

asinck commented 7 years ago

From here, it's possible to edit the ban, thus reactivating it. Idk if that's intended behavior.

asinck commented 7 years ago

The deactivation seems to work correctly though - the page says that the ban has ended.

allejo commented 7 years ago

What do you mean by "deactivation?"

How are you deleting the ban?

asinck commented 7 years ago

I used the "Expire" button. I had to put the ban end date in the future to make that button appear though.

allejo commented 7 years ago

So when you expire a ban, it should return to the bans page? Should you not be able to edit an expired ban? Or what did you have in mind?

asinck commented 7 years ago

I think it might be better to have some sort of visual indication that you're editing a ban that's expired, such as in the in-page title (ie, "allejo's expired ban") or in the button (ie, "Edit Expired Ban" or "Edit/Reactivate Ban"). Up to you.