[WIP] Move to new QueryBuilder

allejo commented 6 years ago

~~Shame on me for deciding to sneak in such a huge change to BZiON's core in a planned point release... 😅 BUT Deeeeeeeeploy Jenkins!~~

This PR has been reassigned to a 0.11.0 release

This PR is dedicated to the restructuring of model statuses in the database and introducing a new query builder, powered by Pixie.

In order to allow for both query builders to coexist, the Pixie powered version has been dubbed QueryBuilderFlex.
- This class name is subject to change.
The practice of using status columns for models has been deprecated.
- Due to SET columns in MySQL being a bad idea, models will be making use of boolean columns for model states (e.g. is_deleted, is_draft, is_public). By making this switch, it'll also allow us to support more databases in the future since the SET column type is not part of the SQL standard.

Progress

Model migration to new QueryBuilder and new status convention.

[ ] ApiKey
[x] Ban
[ ] Conversation
[ ] ConversationEvent
[x] Country
[x] Invitation
[x] Map
[ ] Match
[ ] Message
[x] News
[x] NewsCategory
[ ] Notification
[x] Page
[x] Permission
[x] Player
[ ] Role
[x] Server
[x] Team
[x] Visit

Closes #163

todo[bot] commented 6 years ago

Redirect models with wrong alias when bzion.site.url_type === 'permalink'

https://github.com/allejo/bzion/blob/b0f41c2fe754de92108dc047752d471439264932/src/Model/AliasModel.php#L100-L105

This comment was generated by todo based on a `@todo` comment in b0f41c2fe754de92108dc047752d471439264932 in #186. cc @allejo.

todo[bot] commented 6 years ago

Move this to the Service class

https://github.com/allejo/bzion/blob/456aeefb18ae864471404068977344d18cb80243/src/Database.php#L20-L25

This comment was generated by todo based on a `@todo` comment in 456aeefb18ae864471404068977344d18cb80243 in #186. cc @allejo.

todo[bot] commented 6 years ago

Make this work for PDO, or deprecate it if not needed

https://github.com/allejo/bzion/blob/456aeefb18ae864471404068977344d18cb80243/src/Database.php#L159-L164

This comment was generated by todo based on a `@todo` comment in 456aeefb18ae864471404068977344d18cb80243 in #186. cc @allejo.

todo[bot] commented 6 years ago

When PHP 5.x support is dropped, replace Exception with Throwable

https://github.com/allejo/bzion/blob/456aeefb18ae864471404068977344d18cb80243/src/Database.php#L366-L371

This comment was generated by todo based on a `@todo` comment in 456aeefb18ae864471404068977344d18cb80243 in #186. cc @allejo.

allejo commented 6 years ago

~~As a note to myself, the Seasons page is utterly broken after Player model changes. This page also needs to be ported to the new QueryBuilder.~~ Fixed in d487e6c

allejo / bzion