search

allejok96 / jw-scripts

Index or download videos and sound recordings from jw.org.
GNU General Public License v3.0
49 stars 10 forks source link

New Feautures #20

Closed vbastianpc closed 4 years ago

vbastianpc commented 4 years ago

Thanks to your code, I was able to do something I wanted to do a long time ago: get the subtitles of the videos from tv.jw.org. Now when I remember a phrase from a monthly study, for example, I will be able to know exactly what video it is in. You rock!

Now I will modify an old code that I have to cut up the Bible in sign language, thanks to the markers stored in the metadata. I will do it as an extension to your code, something like jw-signs --lang SCH --quality 720 --download --cut-up [DIR]

allejok96 commented 4 years ago

Thanks for your awesome work. I have to admit, looking over my code some year(s?) later it makes me throw up a little :)

The way classes are used and some functions doesn't make that much sense. So I won't do any major feature updates to the code at this point. I'm working on refactor

allejok96 commented 4 years ago

...ing the code. Haha I accidentally pressed Close pull request while typing. But maybe I'll leave it that way. I'll definitely check out your code though.