allejok96 / jw-scripts

Index or download videos and sound recordings from jw.org.
GNU General Public License v3.0
49 stars 10 forks source link

Symlinks are not created correctly #40

Closed mh166 closed 3 years ago

mh166 commented 3 years ago

First of all: thank you so much for making it so easy to have an offline copy of all the videos available and easily accessible. :)

Unfortunately, I have a problem with -m filesystem: only the two top-level symlinks (for Latest and VoD) are set correctly. Any other symlink is missing "../" in the target, no matter whether it's a video or a folder.

image

As you can see, the symlinks always expect the target to be in the same directory when, in reality, they should be pointing to the parent directory.

This is the command that I used to download the video files and generate the directory structure.

# python3 ./jwb-index -d --since 2020-01-01 -l X -m filesystem --limit-rate 0 --free 2048 /media/jwb-videos
allejok96 commented 3 years ago

Thanks for the good bug report. I actually have fixed this bug in the beta branch, but I had forgotten about it. When I get the opportunity I will push the fix into the master branch...

mh166 commented 3 years ago

Thank you for that quick fix! Works great, now! 👍