search

allen-cell-animated / agave

Other
34 stars 6 forks source link

Refactor for picking #203

Closed toloudis closed 2 months ago

toloudis commented 3 months ago

Two small changes here.

  1. Previous refactor #201 left behind some small bookkeeping that really should have been factored out. This does that, in the pick function. Pick now returns a boolean (as before) and also takes an in/out parameter of the selection code which is the actual pick result.
  2. As seen here, https://github.com/allen-cell-animated/agave/pull/201/files#diff-c5c88e2609315d21a31aad6d4473e934233b5cdd1cc64d6c1a0996929836eb3cL306 , the previous refactor introduced a second k_noSelectionCode in a second place. This change restores the value and makes sure it is only defined in one place.