allen-cell-animated / timelapse-colorizer

A web-based, time-series visualizer for tracked segmented data.

Other

8 stars 1 forks source link

fix: Bad feature values are now shown as NaN instead of Infinity #377

Closed ShrimpCryptid closed 3 months ago

ShrimpCryptid commented 3 months ago

Problem

Closes #329, a bug where NaN values are shown as Infinity.

Estimated review size: tiny, 5 minutes

Solution

Added a comment explaining why Infinity values are stored internally.
Added a check that replaces Infinity values with NaN on the hover tooltip.
Deleted unused shader.
Minor formatting changes to shader code.

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Steps to Verify:

Open the preview link and hover over the cells. Greyed-out cells should appear as NaN instead of Infinity: https://allen-cell-animated.github.io/timelapse-colorizer/pr-preview/pr-377/viewer?collection=https%3A%2F%2Fdev-aics-dtp-001.int.allencell.org%2Fdan-data%2Fcolorizer%2Fdata%2Fnucmorph-apr2024%2Fcollection.json&dataset=Mama+Bear&feature=time&t=396
Compare with main build: https://allen-cell-animated.github.io/timelapse-colorizer/viewer?collection=https%3A%2F%2Fdev-aics-dtp-001.int.allencell.org%2Fdan-data%2Fcolorizer%2Fdata%2Fnucmorph-apr2024%2Fcollection.json&dataset=Mama+Bear&feature=time&t=396

github-actions[bot] commented 3 months ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-06-11 21:26 UTC

github-actions[bot] commented 3 months ago

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	66.82%	4755 / 7116
🔵	Statements	66.82%	4755 / 7116
🔵	Functions	56.45%	118 / 209
🔵	Branches	80.65%	371 / 460

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
src/colorizer/loaders/JsonArrayLoader.ts	30.43%	100%	0%	30.43%	16-58, 64-68

Generated in workflow #967