fix: Fixed bug where units would not appear on the UI.

[ShrimpCryptid]

Problem

Closes #382, a bug where the feature units from newer datasets did not appear on the UI. This was caused by a mismatch in the key it was retrieving ("units" instead of "unit", which is the expected format based on our documentation: https://github.com/allen-cell-animated/colorizer-data/blob/main/documentation/DATA_FORMAT.md#dataset).

Estimated review size: small, 5-10 minutes

Solution

• Feature units will now be loaded with the key unit.
• Changed thresholds to also refer to unit instead of units for consistency.
• Older versions of the manifest will now have features remapped from units to unit.
• Updated unit tests.

Type of change

• Bug fix (non-breaking change which fixes an issue)

Steps to Verify:

1. Load these two older datasets, which use the deprecated dataset format (internally use "units"). Mouse over the features dropdown to make sure that the names of the features look identical.
   • FIXED BUILD: https://allen-cell-animated.github.io/timelapse-colorizer/pr-preview/pr-383/viewer?collection=https%3A%2F%2Fdev-aics-dtp-001.int.allencell.org%2Fdan-data%2Fcolorizer%2Fdata%2Fcollection.json
   • BROKEN BUILD: https://allen-cell-animated.github.io/timelapse-colorizer/viewer?collection=https%3A%2F%2Fdev-aics-dtp-001.int.allencell.org%2Fdan-data%2Fcolorizer%2Fdata%2Fcollection.json
2. Load this newer dataset (internally uses "unit"). Units should appear in the feature dropdown in the new build but not in the old build.
   • FIXED BUILD: https://allen-cell-animated.github.io/timelapse-colorizer/pr-preview/pr-383/viewer?collection=https%3A%2F%2Fdev-aics-dtp-001.int.allencell.org%2Fassay-dev%2Fcomputational%2Fdata%2FEMT_deliverable_processing%2FTranscription_factor_cell_lines%2FVersion_1%2Fcolorizer_output%2FEOMES%2Fcollections_all.json
   • BROKEN BUILD: https://allen-cell-animated.github.io/timelapse-colorizer/viewer?collection=https%3A%2F%2Fdev-aics-dtp-001.int.allencell.org%2Fassay-dev%2Fcomputational%2Fdata%2FEMT_deliverable_processing%2FTranscription_factor_cell_lines%2FVersion_1%2Fcolorizer_output%2FEOMES%2Fcollections_all.json

Screenshots (optional):

[github-actions[bot]]

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-06-18 22:05 UTC

[github-actions[bot]]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	66.98%	4768 / 7118
🔵	Statements	66.98%	4768 / 7118
🔵	Functions	57.41%	120 / 209
🔵	Branches	80.64%	375 / 465

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
src/colorizer/Dataset.ts	79.88%	76.81%	70.58%	79.88%	115-117, 178, 214-215, 233-234, 246-247, 274-280, 294-295, 302-303, 307-309, 313-314, 324-325, 331-332, 335-350, 376-377, 393-402, 430-431, 461-463, 467-468, 472-473, 476-480, 483-507, 514-521
src/colorizer/types.ts	97.01%	100%	60%	97.01%	128-129, 198-201
src/colorizer/utils/data_utils.ts	60.68%	70%	33.33%	60.68%	20-21, 27-32, 66-76, 78-86, 97-102, 115-137
src/colorizer/utils/dataset_utils.ts	100%	100%	100%	100%
src/colorizer/utils/url_utils.ts	94.46%	95.76%	91.3%	94.46%	91-97, 148-154, 184-195, 480-487

Generated in workflow #971