Open ShrimpCryptid opened 6 days ago
github-actions[bot]
commented
6 days ago PR Preview Action v1.4.7
:---:
:rocket: Deployed preview to https://allen-cell-animated.github.io/timelapse-colorizer/pr-preview/pr-394/
on branch gh-pages at 2024-06-24 20:06 UTC
github-actions[bot]
commented
6 days ago | Status | Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔵 | Lines | 67.71% | 4860 / 7177 |
| 🔵 | Statements | 67.71% | 4860 / 7177 |
| 🔵 | Functions | 58.76% | 124 / 211 |
| 🔵 | Branches | 82.13% | 400 / 487 |
| File | Stmts | % Branch | % Funcs | % Lines | Uncovered Lines |
|---|---|---|---|---|---|
| Changed Files | |||||
| src/colorizer/Dataset.ts | 79.88% | 76.81% | 70.58% | 79.88% | 115-117, 178, 214-215, 233-234, 246-247, 274-280, 294-295, 302-303, 307-309, 313-314, 324-325, 331-332, 335-350, 376-377, 393-402, 430-431, 461-463, 467-468, 472-473, 476-480, 483-507, 514-521 |
Problem
Part 2/3 for #20, handling large numbers of features. This code change updates the
DataCacheto allow certain keys to be exempted from eviction; this way, the feature currently being viewed will not have its Texture data unloaded if other parts of the UI are interacted with*.Estimated review size: small, 15 minutes. Lots of unit tests.
*Okay so interesting technical note, it's possible that this may not be an issue because Three.js will not unload Texture objects that are currently being used by a scene. However, it's not behavior that I want to rely on!
Solution
DataCacheas reserved. This will prevent them from being evicted until they are removed from the list of reserved keys.FrameCache.tstoDataCache.ts.Type of change