allen-cell-animated / volume-viewer

https://allen-cell-animated.github.io/volume-viewer/
Other
90 stars 7 forks source link

Subregion type #132

Closed frasercl closed 1 year ago

frasercl commented 1 year ago

Use Case

VolumeCache and IVolumeLoader both define separate types to specify a volume subregion, with different functions to operate on them. As a developer, I'd prefer to work with a single unified type in these files and anywhere else we need to deal with subregions.

Solution

Create a single type for this purpose. Some thoughts:

frasercl commented 1 year ago

Unit test operations on this type

frasercl commented 1 year ago

Resolved by #136 and #137