Rework `LoadSpec` - Githubissues

allen-cell-animated / volume-viewer

https://allen-cell-animated.github.io/volume-viewer/

Other

90 stars 7 forks source link

Rework `LoadSpec` #134

Closed frasercl closed 11 months ago

frasercl commented 1 year ago

Use Case

As a developer, the LoadSpec type doesn't capture all settings that are relevant when loading a volume.

Solution

Remove the subpath field, replace with something like resolutionLevel
Consider giving extent fields in pixels at provided resolution level, rather than 0-1 floats
Add a list of channel indexes to load

toloudis commented 1 year ago

Consider refactor to remove url from LoadSpec and provide it to stateful IVolumeLoaders in ctor. One goal being to help enforce that loadspecs can be the "original" load spec, and also a requested new loadspec that is intended to use the same data source. So a possible alternative is to have two different flavors of LoadSpec. LoadSpec and LoadSpecRequest? or even LoadSpec and LoadSpecWithUrl!