allen-cell-animated / volume-viewer

https://allen-cell-animated.github.io/volume-viewer/
Other
92 stars 7 forks source link

Refactor: update `ImageInfo` #135

Closed frasercl closed 1 year ago

frasercl commented 1 year ago

Problem

Resolves #131: Volume receives a type called ImageInfo on construction which contains essential information about the volume's dimensions. This type is based on the JSON schema used by JsonImageInfoLoader, which is not particularly suited to being a general volume information format:

Solution

ShrimpCryptid commented 1 year ago

image Hey, I'm seeing some artifacting/weird slicing behavior? Is this a setting I have misconfigured or is this happening for you too?

frasercl commented 1 year ago

Hey, I'm seeing some artifacting/weird slicing behavior? Is this a setting I have misconfigured or is this happening for you too?

Could you check that you have the latest version of this branch? I also saw this behavior and fixed it (or attempted to) in 4c143f9.

ShrimpCryptid commented 1 year ago

Hey, I'm seeing some artifacting/weird slicing behavior? Is this a setting I have misconfigured or is this happening for you too?

Could you check that you have the latest version of this branch? I also saw this behavior and fixed it (or attempted to) in 4c143f9.

Okay, yes, that fixed it.