allen-cell-animated / volume-viewer

https://allen-cell-animated.github.io/volume-viewer/
Other
90 stars 7 forks source link

Subregion type part 1: `LoadSpec` #136

Closed frasercl closed 1 year ago

frasercl commented 1 year ago

Addresses #132: there are currently two unconnected areas of the app that care about subregions of the volume, and they use unrelated types to express these subregions. Eventually we will connect these two systems, and it would be nice if they both spoke the same language when we do. This PR and its counterpart (#137) convert both to use three.js's native Box3 type.

This PR converts the subregion fields of LoadSpec (minx, maxx, miny, etc., each of type number) to a single subregion field of type Box3, and deals with the consequences of this: