allen-cell-animated / volume-viewer

https://allen-cell-animated.github.io/volume-viewer/
Other
90 stars 7 forks source link

use setChannelOptions more #159

Open toloudis opened 10 months ago

toloudis commented 10 months ago

Use Case

We have too many code paths for setting the same settings.

Solution

For all of the top-level View3d api calls that set very specific data, we should have their internal implementations all be routed into our more generalized setChannelOptions. We can do this without changing the View3d api.

Alternatives

API changes to deprecate the single setting functions and then enforce setChannelOptions as the only public API is a bigger decision that has less effect on stability and could be considered separately.