search

allen-cell-animated / volume-viewer

https://allen-cell-animated.github.io/volume-viewer/
Other
90 stars 7 forks source link

fix how pathtracer receives updates to colors and lut #170

Closed toloudis closed 9 months ago

toloudis commented 9 months ago

Pathtracer's main updating function for color and LUT updates was updateActiveChannels. This function short-circuits based only on changes to the set of enabled channels, so if you didn't enable/disable a channel, then nothing else would update.

I am fixing this by using our settings MATERIAL flag to let the path tracer receive these updates. Part of the fix is to add the per-channel color to our volume render settings. Over time, we should add more and more per-channel settings to this structure and more and more will be able to use our updateSettings code path.

toloudis commented 9 months ago

I forgot to say, this bug came about when we first implemented the updateSettings code path, and the path tracer was ignored / under-tested.