search

allen-cell-animated / volume-viewer

https://allen-cell-animated.github.io/volume-viewer/
Other
92 stars 7 forks source link

feat: Added error for zarr files that exceed max atlas size #212

Closed ShrimpCryptid closed 5 months ago

ShrimpCryptid commented 5 months ago

Closes #174, handling zarr files that are too large.

Estimated review size: small, 10 minutes

Changes

TODO noted by Dan: For certain datasets, it may be possible to open the Z-slice data but not the 3D data. Should we do parallel checks for both, and switch to 2D mode if it's the only view mode we can support? TODO: Enforce maximum on the number of channels that can be enabled?

Validation

  1. Run volume-viewer locally.
  2. Switch to the new "Fly Brain" Zarr in the dropdown.
  3. Press Ctrl + Alt + 1 to open the developer menu.
  4. Change the maxAtlasEdge to 512. There should be an error message for the 3D view.
  5. Switch to Z-slice mode. The error message should disappear and a slice should appear.
ShrimpCryptid commented 5 months ago

Marking this ready for review but @frasercl @toloudis let me know if there's additional checks or debug features I should include. (We had talked about a few but I wasn't sure if they were requirements or just nice-to-haves.)