allen-cell-animated / volume-viewer

https://allen-cell-animated.github.io/volume-viewer/
Other
92 stars 7 forks source link

on color change in pathtrace mode, we need to update the combined LUT… #26

Closed toloudis closed 3 years ago

toloudis commented 3 years ago

This is a bug that is a regression from adding the colorize mode. In path trace mode, main channel color changes were not updating properly. After this code change, colors update normally.

This happened because the main channel color is now part of the lookup table and is not stored as a separate individual color. (A concession to colorize mode, since this color parameter needs to be per-intensity rather than global to the whole channel.) A further optimization TODO would probably store some kind of "dirty" flag and only update things if something had changed.