search

allen-cell-animated / volume-viewer

https://allen-cell-animated.github.io/volume-viewer/
Other
92 stars 7 forks source link

Feature/nightly build #57

Closed toloudis closed 2 years ago

toloudis commented 2 years ago

Does a nightly build using github-actions, and publishes it to github-pages at allen-cell-animated.github.io/volume-viewer/ The webpack config was modified, so there is no longer a volumeviewer subdirectory when running in dev-server.

toloudis commented 2 years ago

GitHub workflows are new to me, but from what I'm able to learn this looks good. I am curious though: why deploy a development build rather than production?

Good question and I think it's just a matter of misleading file names. The webpack.dev.js is a configuration for the test app, which is what would typically be used during dev to make sure things are working. And that test app is the thing we want to deploy to github-pages.