search

allen-cell-animated / website-3d-cell-viewer

Other
5 stars 5 forks source link

react lifecycle takes significant time during T playback #191

Open toloudis opened 6 months ago

toloudis commented 6 months ago

Description

Channels arriving triggers extra react state manipulation in callbacks. See channel version being incremented (setOneChannelLoaded) which leads to ChannelUpdater re-render, which has lots of dependencies on version in several useeffects.

Expected Behavior

Hopefully we can find ways to reduce the amount of react cpu processing during T playback.

toloudis commented 3 months ago

of note: close transfer function editors and playback speeds up.

toloudis commented 1 month ago

requires profiling and study of how to minimize the work that React is doing when volume data is updated while playback happens.

toloudis commented 1 month ago

idea: during playback, figure out what is the minimal stuff that needs to update (e.g. transfer function editor display only when it is open, and nothing else) and create a targeted code path that only updates that stuff ...?