Recent datasets from colorizer now also appear in GH w3cv build - Githubissues

allen-cell-animated / website-3d-cell-viewer

Other

4 stars 4 forks source link

Recent datasets from colorizer now also appear in GH w3cv build #243

Closed ShrimpCryptid closed 2 months ago

ShrimpCryptid commented 2 months ago

Description

The recent datasets list from colorizer also appears in dropdowns on w3cv on GitHub pages.
The root cause is because both are writing to the same recentDatasets key at the root website (allen-cell-animated.github.io) instead of their respective subpages.

Fix by configuring localStorage write to basename URL passed in during build? Or change name in one or both directories.

Expected Behavior

What did you expect to happen instead?

Reproduction

A minimal example that exhibits the behavior.

Environment

Any additional information about your environment. E.g. OS version, python version, browser etc.

ShrimpCryptid commented 2 months ago

localStorage always writes to origin. I'll change the prefix in w3cv first, but I should also make a fixup for colorizer too. https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage