allen-cell-animated / website-3d-cell-viewer

Other
4 stars 4 forks source link

github-pages deployment is broken today #250

Closed toloudis closed 2 months ago

toloudis commented 2 months ago

Description

https://allen-cell-animated.github.io/website-3d-cell-viewer/viewer?url=https%3A%2F%2Fanima[…]-data.s3.us-west-2.amazonaws.com%2Fvariance%2F116.zarr

Fails to load. It looks like there's maybe a missing "/" in the build path https://allen-cell-animated.github.io/website-3d-cell-viewer_cdec-_753a-_4e4d-_662e.bundle.js

It should be https://allen-cell-animated.github.io/website-3d-cell-viewer/_cdec-_753a-_4e4d-_662e.bundle.js (underscore after website-3d-cell-viewer)

Expected Behavior

the above link should load correctly

ShrimpCryptid commented 2 months ago

Could try editing the package.json build scripts:

    "gh-build-nightly": "webpack --config webpack.dev.js --env env=production basename=/website-3d-cell-viewer",
    "gh-build-release": "webpack --config webpack.dev.js --env env=production basename=/website-3d-cell-viewer-release",