allen-cell-animated / website-3d-cell-viewer

Other
5 stars 4 forks source link

Viewer state management refactor #262

Closed frasercl closed 3 months ago

frasercl commented 4 months ago

Review time: medium-large

Refactors state representation out of App in favor of a new component, ViewerStateProvider.

Some background. This repo is, in a sense, concerned primarily with providing a nice UI for manipulating viewer state. By viewer state, I mean any state which is in some sense a setting of volume-viewer - so whether the bounding box is visible is viewer state, but whether the control panel is open is not. Currently, this state is stored and managed like this:

The changes in this PR move us to managing state like this:

ShrimpCryptid commented 3 months ago

Could you clarify who you wanted to review this PR? (I'm planning to because I'll be working off of these changes, but I saw there are four(!) people listed as requested 😆)

rugeli commented 3 months ago

Could you clarify who you wanted to review this PR? (I'm planning to because I'll be working off of these changes, but I saw there are four(!) people listed as requested 😆)

No worries, I haven't started the review and can opt out!