Fix Z slider causing errors with 2d image

frasercl commented 3 months ago

Review time: small (5-10min)

Resolves #263: Z slider no longer causes an error in 2D XY mode when viewing a 2D image.

The Z clipping slider isn't especially meaningful when viewing a 2d image anyways. Currently, it shows two completely immovable handles in 3d mode, and creates an error in 2d mode. So this PR is really about removing it when the image has no Z dimension in the first place.

Following feedback from @lynwilhelm and the rest of UX, removing the Z slider works like this:

In 3D mode, it's just gone entirely
In 2D mode, the play button disappears and the slider is replaced with a placeholder message. The labels "ROI" and "Z" are preserved.
- Note that, while I don't have a 2D zarr time series to demonstrate in a screenshot below, this allows the condition where the time slider is present alongside the placeholder Z slider.

Screenshots

3D mode:

2D mode:

ShrimpCryptid commented 3 months ago

@frasercl is this ready to merge?

interim17 commented 3 months ago

@frasercl I see two approvals on this, removing myself, but if you want eyes on this again for any reason just re-request me!

allen-cell-animated / website-3d-cell-viewer

Fix Z slider causing errors with 2d image #269

Screenshots