feature: Serialization + deserialization of viewer state - Githubissues

allen-cell-animated / website-3d-cell-viewer

Other

4 stars 4 forks source link

feature: Serialization + deserialization of viewer state #271

Closed ShrimpCryptid closed 3 weeks ago

ShrimpCryptid commented 1 month ago

Second part of progress towards #107. Adds serialization and deserialization of the new ViewerState introduced by @frasercl and associated unit tests.

Estimated review size: medium, ~30 minutes. (~300 lines are unit tests.)

Changes

Adds methods for serializing and deserializing the ViewerState type.
Adds a method for serializing the ChannelState.
- Currently missing handling for control points-- pending a PR @frasercl is working on
Adds unit tests for serializing/deserializing viewer state types.

ShrimpCryptid commented 3 weeks ago

Thanks, y'all! I'm going to work on making some of the changes Megan suggested (probably should have marked it as draft while that was happening). Appreciate the eyes on this PR though :')