search

allen-cell-animated / website-3d-cell-viewer

Other
5 stars 5 forks source link

Don't rename channels in `ChannelState` #325

Open ShrimpCryptid opened 1 week ago

ShrimpCryptid commented 1 week ago

Description

If a channel matches a group in ViewerChannelSettings, it's currently renamed and the original channel name is not stored anywhere in ChannelState. Consider changing the ChannelState to have a displayName and preserve the original name field?

Expected Behavior

What did you expect to happen instead?

Reproduction

A minimal example that exhibits the behavior.

Environment

Any additional information about your environment. E.g. OS version, python version, browser etc.

toloudis commented 5 days ago

I suspect this is an error that was never the intended behavior but I'll take a look at git history and check.