allen505 / save-for-later

A web extension for Chrome/Firefox which saves the tabs in current window for later use.
https://allen505.github.io/save-for-later/contribute
GNU General Public License v3.0
34 stars 12 forks source link

Open all tabs in a private window #2

Closed dardoor closed 1 year ago

dardoor commented 4 years ago

It seems there's no way to open all the saved tabs at once (the whole session) in a private window. Even if you're already in a private window, they open in a regular window.

You can only open them individually, if you're already in a private window, by L-clicking (middle click doesn't work). That's better than nothing, but I wish you could open them all at once.

allen505 commented 4 years ago

This is a good idea. The save opened should reflect the type of window (normal/private) that it is opened in. To check whether the extension is in a private window inIncognitoContext could be used, (research required) To open the tabs in a private window, windows.create can be used with the incognito flag set to true.

Abbaskt commented 1 year ago

inIncognitoContext cannot be used as it will not recognize a private window until "incognito": "split" is mentioned in the Manifest files as stated here. Instead an example mentioned here can be used to derive if the last tab was a private tab or not.

allen505 commented 1 year ago

Sure, makes sense

allen505 commented 1 year ago

Closing this issue as the PR is merged. Thanks @Abbaskt