allen505 / save-for-later

A web extension for Chrome/Firefox which saves the tabs in current window for later use.
https://allen505.github.io/save-for-later/contribute
GNU General Public License v3.0
33 stars 11 forks source link

Editable title for each Save #4

Closed dhruvitahrishi closed 1 year ago

allen505 commented 4 years ago

Thank you for your interest @dhruvitahrishi ! This is surely a useful feature to have.

Implementation Details

Let me know if you are interested in working on this feature.

AB047 commented 4 years ago

I think this is going to be an easy fix, I can do this.

allen505 commented 4 years ago

Definitely @AB047 you can give a try. Please have a look at my message above implementation details. For any further clarifications please drop your questions on this thread

emecas commented 4 years ago

Experimenting with editable titles

image

Experimenting with available area keeping intact title information

image

allen505 commented 4 years ago

This is amazing work @emecas . The first image is exactly what I had in mind as mentioned in this comment. Since the text will be editable, we need to have a seperate button which will launch all the tabs in a new window with a logo similar to this. We have to shift all the icons to the right side however as to me it looks a bit odd to have unevenly distributed icons. I will repeat the implementation details of the Editable text in the begining of this thread too for reference.

Please do let me know if you are interested to work on this. One thing I forgot in the developement setup is to create a new branch to keep your feature implementation seperate from the master branch code. To do this enter: git checkout -b <new-branch-name> in a terminal.

emecas commented 4 years ago

Thanks @allen505

Following your indications and priorities, I'm working on this issue first and almost done.

Progresses:

To do

For now I was having issues with 2 things:

Final Result:

image

allen505 commented 2 years ago

Adding some changes which are to be addressed:

emecas commented 2 years ago

Adding some changes which are to be addressed:

* To make the changes less jarring for the end users, I'm looking to make an edit button which enables the editableContent and a click on the Title to open the Save, as it was previously. This also gives more click area for most used feature which would be to repoen the Saves

* Space is not accepted in Chrome

* Title String Validations Required:

  * Empty String is being accepted
  * Very long Titles are accepted

hi @allen505, are you working on this currently? I could give this another try, I just need to know where we are

allen505 commented 2 years ago

Hey @emecas , I had started on the changes but couldn't find the time to complete it. You can pick it up some parts of this if you are available

allen505 commented 1 year ago

Closing this issue