allen8807 / memcached

Automatically exported from code.google.com/p/memcached
0 stars 0 forks source link

Source code ( a joke probably ) #215

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I don't know what to say but I am not sure if this I get you correctly, here is 
memcached.c:

 166 /** exported globals **/
 167 struct stats stats;
 168 struct settings settings;
 169 static time_t process_started;     /* when the process was started */

The static on last line is pretty hilarious if the I consider the first line of 
comment to be true. Is it really an issue or is it just me?

Original issue reported on code.google.com by zohaib.h...@gmail.com on 9 Aug 2011 at 8:44

GoogleCodeExporter commented 9 years ago
Please don't use the bug tracker for commentary. If you have a question, e-mail 
the list directly or ask in IRC.

the first two lines are globals, the third one is obviously not. who cares?

Original comment by dorma...@rydia.net on 9 Aug 2011 at 8:58

GoogleCodeExporter commented 9 years ago
Please checkout engine-pu/engines/default_engine/items.c Line 386 I don't know 
if you have gone through code of this part but process_started is something 
that really makes sense of being global. So it you should care :) now

Original comment by zohaib.h...@gmail.com on 10 Aug 2011 at 4:57

GoogleCodeExporter commented 9 years ago
This is not a bug. This is pedantic.

Original comment by dorma...@gmail.com on 10 Aug 2011 at 5:10

GoogleCodeExporter commented 9 years ago
it wont compile if you don't remove static and I discovered it when I got 
compile error last night. So may be ignoring it is a bad idea. 

Original comment by zohaib.h...@gmail.com on 10 Aug 2011 at 7:00