allenai / OLMo

Modeling, training, eval, and inference code for OLMo
https://allenai.org/olmo
Apache License 2.0
4.37k stars 431 forks source link

Improving memmap type parser #663

Closed soldni closed 1 month ago

soldni commented 1 month ago

The old effective_memmap_dtype property will default to uint16 in case the dtype provided is not valid. This is bad because, as @drschwenk found, value numpy.uint32 will cause uint16 to be used.

New property will raise an TypeError if dtype is not recognized.