search

allenai / PeerRead

Data and code for Kang et al., NAACL 2018's paper titled "A Dataset of Peer Reviews (PeerRead): Collection, Insights and NLP Applications"
389 stars 99 forks source link

Download NIPS dataset #28

Closed Tristan-Chow closed 5 years ago

Tristan-Chow commented 5 years ago

line 40 in NIPS_crawl.py str(data).split("\n") It returns me a list with only one element(the whole string), it seems the splitting code does not work.

roys174 commented 5 years ago

The code works with python2.7 (sorry, this should mentioned in the README file). @dykang?

dykang commented 5 years ago

@roys174 would you please review #29 and merge?

roys174 commented 5 years ago

Thanks. I am not sure but I think all our repo works just with python 2, doesn't it?

On Wed, May 1, 2019 at 4:28 PM Dongyeop Kang notifications@github.com wrote:

@roys174 https://github.com/roys174 would you please review #29 https://github.com/allenai/PeerRead/pull/29 and merge?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/allenai/PeerRead/issues/28#issuecomment-488490235, or mute the thread https://github.com/notifications/unsubscribe-auth/ADNKL2TVBADBCTSJSGTMYZLPTIRTRANCNFSM4HI26LRA .

dykang commented 5 years ago

It is. But, I recently changed all printing functions compatible with python 3. Thus, NIPS_crawl.py is the only code which is not compatible with Python 2. Python 3 doesn't support some modules in the code.

ddofer commented 2 years ago

Has this bug been fixed, or does the code depend still on PY2? (+- a hack to fix that specific function)? Tx