allenai / S2AFF

link raw affiliation to ROR ids
Apache License 2.0
24 stars 4 forks source link

Timofy #1

Closed sergeyf closed 2 years ago

sergeyf commented 2 years ago

Note: tt verfiy was run with cuda: False because s2-server2 is too old. It's still False in the config, but actually it should work fine with cuda: True

CC @kelseym-ai2

cmwilhelm commented 2 years ago

Ah @sergeyf . We chatted about this in slack, but I need to move a particular validation hook to tt verify that's only in tt publish. tldr: you need to add a description= metadata field to your setup.py.

sergeyf commented 2 years ago

Thanks @cmwilhelm. I've addressed your comments.

kelseym-ai2 commented 2 years ago

How was the gold test data set created? Like what was it sampled from?

sergeyf commented 2 years ago

@kelseym-ai2 the story of the gold data is sort of complicated and not well documented. In 2021, we did a first annotation for data I sampled from MAG in some . Then we decided we needed more data so I sampled more data from OpenAlex in .

sergeyf commented 2 years ago

I have now published @cmwilhelm:

(s2aff_release) sergey@s2-server2.corp ~/S2AFF-release $ tt publish -c s2aff/timo/config.yaml
Publishing your package to pip.s2.allenai.org as s2aff==0.1...
Published successfully to: https://pip.s2.allenai.org/#/package/s2aff
Publishing your model config to TIMO Registry for s2aff==0.1...