search

allenai / ScienceWorld

ScienceWorld is a text-based virtual environment centered around accomplishing tasks from the standardized elementary science curriculum.
https://sciworld.apps.allenai.org/
Apache License 2.0
199 stars 24 forks source link

Fix typos #32

Closed aphedges closed 1 year ago

aphedges commented 1 year ago

As a follow-up to #28, I have fixed some more typos in the codebase.

I also updated the JAR version in package.sh so it would build properly.

PeterAJansen commented 1 year ago

Looks good, most of these typos are in the code comments.

There is also a change to the JAR file version. Can you verify this is accurate @MarcCote ?

aphedges commented 1 year ago

@PeterAJansen, the JAR file version was changed in ce05307115a099d1cf9d905a4f9d1da47cdf9ddc. That commit missed changing the build script, so I fixed it here.

MarcCote commented 1 year ago

Yes, I have the same change in my local version. We can merge.

-Marc-

On Thu., Nov. 3, 2022, 16:49 Alex Hedges, @.***> wrote:

@PeterAJansen https://github.com/PeterAJansen, the JAR file version was changed in ce05307 https://github.com/allenai/ScienceWorld/commit/ce05307115a099d1cf9d905a4f9d1da47cdf9ddc. That commit missed changing the build script, so I fixed it here.

— Reply to this email directly, view it on GitHub https://github.com/allenai/ScienceWorld/pull/32#issuecomment-1302647427, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFBEJGRL6GXMTP43ZHWEGLWGQQOBANCNFSM6AAAAAARVLS2QI . You are receiving this because you were mentioned.Message ID: @.***>