search

allenai / ScienceWorld

ScienceWorld is a text-based virtual environment centered around accomplishing tasks from the standardized elementary science curriculum.
https://sciworld.apps.allenai.org/
Apache License 2.0
199 stars 24 forks source link

Type Hinting #58

Open AndKaminer opened 8 months ago

AndKaminer commented 8 months ago

This goes well with #54, but since technically type hinting isn't part of PEP 8, I pulled it out here. Is type hinting something we want to do? We can check it with something like mypy, which can be automated just like unit testing and flake8. Thoughts?

MarcCote commented 8 months ago

Type hinting is always great. I like the idea of running mypy but I wouldn't make it as a mandatory check for now.