Closed AndKaminer closed 8 months ago
@AndKaminer I made PR to your branch with the changes I have in mind. https://github.com/AndKaminer/ScienceWorld/pull/1
This is how it looks like when it is running https://github.com/allenai/ScienceWorld/actions/runs/7289142662
@AndKaminer I made PR to your branch with the changes I have in mind. AndKaminer#1
This is how it looks like when it is running https://github.com/allenai/ScienceWorld/actions/runs/7289142662
Thanks for doing that. Sorry for taking out a PR and ghosting. I had some unexpected things come up. I'll take a look.
@AndKaminer I made PR to your branch with the changes I have in mind. AndKaminer#1 This is how it looks like when it is running https://github.com/allenai/ScienceWorld/actions/runs/7289142662
Thanks for doing that. Sorry for taking out a PR and ghosting. I had some unexpected things come up. I'll take a look.
Looks great! I just merged on my branch, so it should be good to merge here.
@AndKaminer I made PR to your branch with the changes I have in mind. AndKaminer#1 This is how it looks like when it is running https://github.com/allenai/ScienceWorld/actions/runs/7289142662
Thanks for doing that. Sorry for taking out a PR and ghosting. I had some unexpected things come up. I'll take a look.
No worries. Thanks for initiating all the changes.
Fixes #60
Use this github action to setup scala. Then run package.sh. If it fails, the test fails and vice versa. The only problem with this is that it behaves oddly on Windows. The action can only pass on windows. It never fails, even when it fails on unix-based systems.
This ^ is the output of the test on Windows.
Whereas this ^ is the output on unix systems.
It appears to me that the script isn't even running on windows. Unfortunately, I don't have a windows machine, so I can't directly test on windows.
Regardless, if something goes wrong with the compilation, tests do still fail. You just only see it in macos or ubuntu.