allenai / ai2thor

An open-source platform for Visual AI.
http://ai2thor.allenai.org
Apache License 2.0
1.15k stars 216 forks source link

add SpawnBoxCollider func #1189

Closed KuoHaoZeng closed 6 months ago

KuoHaoZeng commented 7 months ago

The newly added SpawnBoxCollider function generates a box with an active collider encapsulates the agent. Currently, it only supports the Stretch agent.

New augments:

  1. useFPINCollider: bool. When set to True, SpawnBoxCollider is included during the initialization phase. If False, initialization proceeds as previously.
  2. colliderScaleRatio: dict. It specifies the scale ratio of the box along each axis, for example, {"x": 1.0, "y": 1.0, "z": 1.0}. A value of 1.0 indicates that the box size matches the detected bounds.
KuoHaoZeng commented 6 months ago

Update

AlvaroHG commented 6 months ago

Nothing jumps out, and looks good. But what I recommend to make sure things work as expected, and easier for the reviewers to understand how the code should work is creating some unit tests :) LGTM after some minor comments