allenai / ai2thor

An open-source platform for Visual AI.
http://ai2thor.allenai.org
Apache License 2.0
1.15k stars 215 forks source link

Fixing collision checks to work correctly with convex colliders. #1230

Closed Lucaweihs closed 1 month ago

Lucaweihs commented 1 month ago

The old isObjectColliding function did not check for mesh colliders as all dynamic objects previously used only primitive colliders. This changed with Objaverse and so this function needed to be updated.

This commit also includes a change to how the skybox is setup when a procedural house is loaded with a uniform color skybox. The idea here is that we don't want the skybox to effect lighting in the scene as this can result in some really weird behavior (i.e. objects rendered on a pure white background are very overexposed).

AlvaroHG commented 1 month ago

Looks good!