Closed twni2016 closed 2 years ago
This pull request introduces 11 alerts when merging 4a4fd5f33b64311f09c9c0947fbe59b40ced3d0c into 894c2ce1b7d89402419474829a6f308d225bec6f - view on LGTM.com
new alerts:
This pull request introduces 13 alerts when merging fee80031469a89967803bfeeabc7a7b22764faf1 into eb2c12e5759ed0f1b02a41cdd0e48efcbb2384b2 - view on LGTM.com
new alerts:
Most of comments have been resolved. I've refactored the logging by using save_dir_fmt
argument.
Remaining issues:
I use the following script for testing:
python main.py projects/objectnav_baselines/experiments/robothor/objectnav_robothor_rgb_unfrozenresnet_gru_ddppo.py \
-s 302 --save_dir_fmt NESTED \
-o experiment_output/objectnav/
python main.py projects/pointnav_baselines/experiments/robothor/pointnav_robothor_depth_simpleconvgru_ddppo.py \
-s 302 --save_dir_fmt NESTED \
-o experiment_output/pointnav/
Shall we also add these running scripts into somewhere in the doc?
This pull request introduces 13 alerts when merging 8479e03ec627cce9c84bc7c7582fdedaaeca03df into eb2c12e5759ed0f1b02a41cdd0e48efcbb2384b2 - view on LGTM.com
new alerts:
This pull request introduces 13 alerts when merging 21bf39d878d35fdf08e3e2112b7f1488a7458333 into eb2c12e5759ed0f1b02a41cdd0e48efcbb2384b2 - view on LGTM.com
new alerts:
These LGTM alerts are not coming from my code. Shall I resolve them? @Lucaweihs
@twni2016 - We might be looking at different LGTM pages but you can find some alerts in your new files here. These are mostly about unused imports but there also appear to be 2 instances of unused local variables.
I see. I clicked the alert
button in LGTM webpage which shows other lines.
This pull request introduces 13 alerts when merging 074e5ac0c4fad7650f4650702864fdcd91cd4c21 into eb2c12e5759ed0f1b02a41cdd0e48efcbb2384b2 - view on LGTM.com
new alerts:
@Lucaweihs I have fixed the key mismatch issue in objectnav checkpoint. The script
python main.py projects/objectnav_baselines/experiments/robothor/objectnav_robothor_rgbd_resnetgru_ddppo.py \
-s 1 --save_dir_fmt NESTED --infer_output_dir --eval -i \
-c pretrained_model_ckpts/robothor-objectnav-challenge-2021/Objectnav-RoboTHOR-RGBD-ResNetGRU-DDPPO/2021-02-09_22-35-15/exp_Objectnav-RoboTHOR-RGBD-ResNetGRU-DDPPO_0.2.0a_300M__stage_00__steps_000170207237.pt
But, I cannot find the experiment config robothor-pointnav-rgb-resnet
for pointnav checkpoint, so I cannot run it. By the way, the wget script pretrained_model_ckpts/download_navigation_model_ckpts.sh
download the ckpt into pretrained_model_ckpts
for objectnav while into the root dir for pointnav. I think they should be consistent.
This pull request introduces 5 alerts when merging 2d8c4800745ac25497c14391229be15826e88313 into eb2c12e5759ed0f1b02a41cdd0e48efcbb2384b2 - view on LGTM.com
new alerts:
This pull request introduces 2 alerts when merging 387d9d83b45de334f228aeb287fcaa49b24b6282 into eb2c12e5759ed0f1b02a41cdd0e48efcbb2384b2 - view on LGTM.com
new alerts:
This PR includes:
VisualNavActorCritic
to be inherited from different downstream navigation model classes (i.e. code refactoring), and also add the modified ResNet18 from https://github.com/joel99/habitat-pointnav-auxI tested the change by running commands: