search

allenai / allennlp-as-a-library-example

A simple example for how to build your own model using AllenNLP as a dependency.
113 stars 51 forks source link

Upgrade to AllenNLP 0.5.1 #13

Closed nelson-liu closed 6 years ago

nelson-liu commented 6 years ago

This PR upgrades to AllenNLP 0.5.1 . I retrained the model and got a best validation accuracy of 0.8125 at epoch 9, consistent with what's reported in the tutorial

I added a test for the issue reported in #10 and verified that the patch in #10 fixed it. I also pulled in the commit from #12 , since the tests wouldn't run otherwise.

happy to provide the trained model, but I don't think it's used anywhere?

nelson-liu commented 6 years ago

cc: @joelgrus , since it doesn't seem like you're "watching" this repo and @matt-gardner is OOT.

nelson-liu commented 6 years ago

@joelgrus any further thoughts on this now that https://github.com/allenai/allennlp/pull/1418 is in?

joelgrus commented 6 years ago

make a new release and upgrade it to use the new release

nelson-liu commented 6 years ago

ok, so just skip 0.5.1? I'm fine with that. I'll leave this open for now until 0.5.2 is released to cherry-pick changes from.

schmmd commented 6 years ago

Closing in favor of https://github.com/allenai/allennlp-as-a-library-example/pull/15