search

allenai / allennlp-hub

A collection of selected of models built with AllenNLP.
Apache License 2.0
25 stars 9 forks source link

Adds reading comprehension dependency #11

Closed dirkgr closed 4 years ago

dirkgr commented 4 years ago

This will probably not work yet.

dirkgr commented 4 years ago

This won't work until https://github.com/allenai/allennlp-reading-comprehension/pull/15 is merged.

dirkgr commented 4 years ago

The sketchy thing is that the results of all the semparse tests changed when I updated the semparse version. Those results look reasonable, not random, but I'm not into those tasks enough to know whether they are expected changes.

dirkgr commented 4 years ago

Apparently there are different results again when this runs in TC.

brendan-ai2 commented 4 years ago

Yeah, the diff looks pretty minor. IIRC we've seen this before when some dependency (Spacy?) updates. Maybe add a no-op diff to each requirements.txt file in order to break the Docker caching? I suspect your change will pass then (assuming you have the newest version of the dependency) and we can go ahead with the change. If it doesn't pass, the outdated deps may be on your end.