search

allenai / allennlp-hub

A collection of selected of models built with AllenNLP.
Apache License 2.0
25 stars 9 forks source link

Update model URLs to models that are compatible with AllenNLP 1.0 #14

Closed matt-gardner closed 4 years ago

matt-gardner commented 4 years ago

This fixed the tests for me locally; not sure if my local install is set up right, though. I thought I'd need to update something else, but this seemed like it was enough. We'll see what this CI says.

matt-gardner commented 4 years ago

As I'm going through some other API cleanup, I'm discovering that there are more config file changes that I want to make. I think it makes sense to hold off on fixing these tests until we're done with any config file changes. It's pretty time consuming to fix the models here, and so I'd rather not duplicate that work every time I make a breaking config file change.

Holding off on this PR until a few other things are merged in the main repo (at least: https://github.com/allenai/allennlp/pull/3627 and https://github.com/allenai/allennlp/issues/3657).

rmporsch commented 4 years ago

Thanks a lot @matt-gardner for all the work and effort making the repo allennlp 1.0 ready. Was trying to use some pretrained models and was wondering if this PR is still on hold since https://github.com/allenai/allennlp/issues/3657 and allenai/allennlp#3627 seem to be closed.

matt-gardner commented 4 years ago

@dirkgr picked this up in #15. I'm closing this PR in favor of that one. If you look at that PR, you'll see updated models for most of what we have in the hub.